Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React tables migration #540

Merged
merged 8 commits into from
Jul 14, 2023
Merged

React tables migration #540

merged 8 commits into from
Jul 14, 2023

Conversation

AmbossKeegan
Copy link
Collaborator

  • finished code-wide migration to Tanstack react-tables
  • deleted old dependency & files
  • updated package.json / package-lock.json

@secondl1ght secondl1ght self-requested a review June 23, 2023 18:53
secondl1ght
secondl1ght requested changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@secondl1ght secondl1ght left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, left some comments inline!

src/client/src/views/chain/transactions/ChainTransactions.tsx Show resolved Hide resolved
src/client/src/views/chain/transactions/ChainTransactions.tsx Show resolved Hide resolved
src/client/src/views/chain/utxos/ChainUtxos.tsx Show resolved Hide resolved
src/client/src/views/chain/utxos/ChainUtxos.tsx Show resolved Hide resolved
src/client/src/views/chain/utxos/ChainUtxos.tsx Show resolved Hide resolved
src/client/src/views/home/reports/mempool/index.tsx Show resolved Hide resolved
src/client/src/components/table/ColumnConfigurations.tsx Show resolved Hide resolved
src/client/src/components/table/DebouncedInput.tsx Show resolved Hide resolved
src/client/src/components/table/index.tsx Show resolved Hide resolved
src/client/src/components/table/index.tsx Show resolved Hide resolved
@secondl1ght secondl1ght self-requested a review June 28, 2023 20:24
@apotdevin apotdevin enabled auto-merge (squash) July 5, 2023 21:28
@apotdevin apotdevin merged commit ec2857b into master Jul 14, 2023
1 check passed
@apotdevin apotdevin deleted the react-tables-migration branch July 14, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@secondl1ght secondl1ght secondl1ght approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AmbossKeegan @secondl1ght @apotdevin